feat: allow enabling / disabling retries manually #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to allow manually (and conveniently) overriding the retry flag on a per-test basis.
I feel like most people tend to configure their TestTransports with disabled retries (globally).
However, when trying to test for instance a custom retry strategy, error listener, etc. I would like to enable retries just for this test case.
P.S. Thanks for this great Bundle. I just refactored a code base that had a custom variation of this with an InMemoryTransport. Was able to get rid of a lot of custom code and ended up with easier tests.