Merged
Conversation
Member
|
Wow @smnandre, this is really great. Yep, you're right, let's pull the plug on a 1.0. If you resolve the conflict and push, I've re-enabled the CI |
# Conflicts: # composer.json
a21bbb7 to
61d823a
Compare
To ensure mb_ltrim mb_rtrim availability for php <8.14
Member
|
mb_trim is in the 84 polyfill. In my other packages, I just didn't use it to avoid the dep (you just have to be sure to run cs fixer with 8.3 locally) |
kbond
reviewed
Feb 12, 2026
Member
|
Thanks Simon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test coverage now > 90%
I'm thinking this could be a serious candidate to a 1.0 stable release ?
Did bump PHP to 8.3 in order to have modern PHPUnit support
What do you think @kbond @nikophil ?
Dependency and Compatibility Updates:
.github/workflows/ci.ymlDocumentation Improvements:
README.mdTesting and Quality Enhancements:
phpunit.xml.distto separate functional and unit testsdump,dd) with@codeCoverageIgnoreOther Code Changes:
NodeconstructorprotectedisVisible()method inNodeto check forhiddenattributes,type="hidden", and inlinedisplay:none/visibility:hiddenstyles, providing a more robust visibility check===) is used in assertion methods for field and selected value equality, increasing accuracy and preventing subtle bugs