Skip to content

Increase coverage and bump deps#9

Merged
kbond merged 5 commits intozenstruck:1.xfrom
smnandre:tests/phpunit-coverage
Feb 12, 2026
Merged

Increase coverage and bump deps#9
kbond merged 5 commits intozenstruck:1.xfrom
smnandre:tests/phpunit-coverage

Conversation

@smnandre
Copy link
Contributor

@smnandre smnandre commented Feb 11, 2026

Test coverage now > 90%

I'm thinking this could be a serious candidate to a 1.0 stable release ?

Did bump PHP to 8.3 in order to have modern PHPUnit support

What do you think @kbond @nikophil ?


Dependency and Compatibility Updates:

  • Increased the minimum required PHP version to 8.3
  • Updated the CI workflow in .github/workflows/ci.yml

Documentation Improvements:

  • Rewrote README.md

Testing and Quality Enhancements:

  • Refactored phpunit.xml.dist to separate functional and unit tests
  • Increased test coverage > 97%
  • Marked debugging methods (dump, dd) with @codeCoverageIgnore

Other Code Changes:

  • Made the Node constructor protected
  • Improved the isVisible() method in Node to check for hidden attributes, type="hidden", and inline display:none/visibility:hidden styles, providing a more robust visibility check
  • Ensured strict comparison (===) is used in assertion methods for field and selected value equality, increasing accuracy and preventing subtle bugs

@kbond
Copy link
Member

kbond commented Feb 11, 2026

Wow @smnandre, this is really great. Yep, you're right, let's pull the plug on a 1.0.

If you resolve the conflict and push, I've re-enabled the CI

# Conflicts:
#	composer.json
@smnandre smnandre force-pushed the tests/phpunit-coverage branch from a21bbb7 to 61d823a Compare February 12, 2026 11:23
To ensure mb_ltrim mb_rtrim availability for php <8.14
@kbond
Copy link
Member

kbond commented Feb 12, 2026

mb_trim is in the 84 polyfill.

In my other packages, I just didn't use it to avoid the dep (you just have to be sure to run cs fixer with 8.3 locally)

@kbond
Copy link
Member

kbond commented Feb 12, 2026

Thanks Simon!

@kbond kbond merged commit 6f9bc7d into zenstruck:1.x Feb 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants