-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Move camera to object #709
base: master
Are you sure you want to change the base?
Improve Move camera to object #709
Conversation
Alternate CQB mode for Move camera to selected entity key CQB mode moves camera to top-rear of object bounding box Useful when unit is inside multi-floor structure. Repeated keypresses switch between modes
Looks like the base game keybind behaviour is still visible and there is a "flicker" before the camera is moved to the CQB view. Ideally, we should override the behaviour of the base game keybind. |
I can add a keybind set to block the base game key. The base game behaviour is kind of weird, it looks up at flying aircraft which is totally useless, and ends up toggling between angles on subsequent presses. What do you think? |
Yeah, that could work. Maybe also consider the size of the object and a minimum distance. |
addons/editor/initKeybinds.sqf
Outdated
if (!isNull curatorCamera) then { | ||
[] call FUNC(handleCuratorMoveCamTo) | ||
}; | ||
}, {}, [DIK_F, [false, false, false]]] call CBA_fnc_addKeybind; // Default: F |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dislike adding a separate keybind. Let's use the KeyDown EH to override the vanilla keybind. If we want to make this optional, could add a setting like "Move Camera To Behaviour" - maybe 3 options: default, CQB mode, and CQB + alternative far view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah ok. Should this code go in camera
instead of editor
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think editor
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the setting belong under camera? see settings screenshot up top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Normally, all the keybind handling is in editor
component but I guess with the setting, it would make more sense to be under camera
. Not really sure what option is the best.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I've implemented everything in editor
, with the setting using the camera
category.
Just noticed current method breaks vanilla lock camera to object =( |
When merged this pull request will: