-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Throw Grenade context menu action #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently a bit iffy.
Here you can see a unit is asked to throw but they just stop and move on
If the whole squad is selected and then you ask them to throw, they will ignore you completely and not even stop (only observed when asked to throw an IR grenade).
Sometimes when running and the whole squad is selected and after their first command they'll do nothing and at some point, they'll react if you ask again.
I can't reproduce the issue in the gif. I can't find a problem specific to the IR grenade, working for me. Was there anything specific (behaviour change) applied to that group? For the second, are you sure that the position was in range. I added a notification for when not all units are in range of the position but, the units should always stop/react since this disables their |
No idea if I was in the range as it is not displayed clearly for the user. Have you tried running different mods with it and seeing if that makes a change? |
Does this integrate with #371 or what happens with this PR? |
? |
Not really sure. Both don't handle in-combat units that well at the moment. |
Now works more consistently for units in combat. Also, updated to use new commands/features such as hash maps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise looks good.
When merged this pull request will:
isSwimming
common functionImage