Skip to content

add Shortcut for Spliting, Expanding and Closing Glance #9821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

add Shortcut for Spliting, Expanding and Closing Glance #9821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions src/zen/kbs/ZenKeyboardShortcuts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,6 +650,40 @@ class nsZenKeyboardShortcutsLoader {
'zen-compact-mode-shortcut-show-toolbar'
)
);
// Glance mode's KeySet
newShortcutList.push(
new KeyShortcut(
'zen-glance-expand',
'Enter',
'',
'',
'',
'cmd_zenGlanceExpand',
'zen-glance-shortcut-expand'
)
);
newShortcutList.push(
new KeyShortcut(
'zen-glance-split',
'S',
'',
'',
'',
'cmd_zenGlanceSplit',
'zen_glance-shortcut-split'
)
);
newShortcutList.push(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esc is already a shortcut, purposefully done on the content process. I'd do the same with the other shortcuts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What content process. were would I need to add 'ESC'ape instead? thanks for the input.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESC key is arleady added, im saying that the other shortcuts should be added there as well.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to this line? The Esc key is hardcoded in this case.

How would you add the other hotkeys while making the hotkeys customiseable in ZenGlanceManager.mjs?

new KeyShortcut(
'zen-glance-close',
'Escape',
'',
'',
'',
'cmd_zenGlanceClose',
'zen-glance-shortcut-close'
)
)

// Workspace shortcuts
for (let i = 10; i > 0; i--) {
Expand Down