-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: improve tab navigation and cycling #9441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Cycling though unloaded tabs and loaded tabs is not bad. I like the idea of adding shortcuts too tabs but I feel that could get messy; unless you only apply it to a few tabs. |
We already have the default shortcuts for tab cycling in general, which are |
) | ||
); | ||
data.push( | ||
new KeyShortcut( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a shortcut I would just have it as a global preference it can be toggled, removing toggleUnloadedCycling
at the same time.
This PR includes commits based on the feature request from #8681
It sets up custom fields for tab navigation within the 'Keyboard Shortcuts' section and also introduces a new section with two radio options under 'Tab Management'. These options allow users to decide whether they should cycle through unloaded tabs while navigating with shortcuts. Additionally, this same configuration can be bound to a shortcut for quick toggling.
I am aware someone tried to add custom shortcuts for tab navigation many months ago, but it was discontinued and unfinished, so I've made this.
I attempted to set the default shortcuts for tab cycling to 'Ctrl + Tab' and 'Ctrl + Shift + Tab', so that people who were already used to those would not have to go through the struggle of setting these manually on the custom fields. However, the 'Ctrl + Shift + Tab' combination did not function as expected. Because of that, I've decided to leave these default keybinds undefined for the time being and submit this PR for Cheff to check it out.
The l10n PR related to this is right here.