Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub actions #379

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Replace Travis CI with GitHub actions #379

merged 6 commits into from
Aug 28, 2023

Conversation

shakeelmohamed
Copy link
Member

@shakeelmohamed shakeelmohamed commented Oct 17, 2021

Travis CI and Codeclimate have been broken for months.
I'm not sure what's wrong, let's give actions a try

Zombie tests are hanging, probably a good time to switch to puppeteer now https://github.com/puppeteer/puppeteer

@shakeelmohamed shakeelmohamed changed the title try adding github actions Replace Travis CI with GitHub actions Oct 17, 2021
@shakeelmohamed shakeelmohamed mentioned this pull request Oct 18, 2021
3 tasks
@Dragonashes
Copy link
Contributor

Dragonashes commented Oct 19, 2021

The yellow warnings related to CSS cant cause it, it runs tasks which is confusing but also good. It hangs and based on time running i would think the red error is a timeout.

The yellow warning
Warning: 83:9 warning Unexpected console statement no-console
Warning: 260:13 warning Unexpected console statement no-console
Warning: 325:5 warning Unexpected console statement no-console

is likely the cause

I am not sure what uses no-console but the .yml says ESLINT, it says here https://eslint.org/docs/rules/no-console that it is used for debugging; I dont know if that is what prints messages to github but perhaps it is supposed to be off on Githubs virtual machines? which could possibly mean, if the (.codeclimate.yml ?) file syntax is right that

no-console:
        enabled: true

might fix it or removing the line if that works.

only other thing i can think of is .travis.yml has a node.js 8/10 version but 14.18.1 is latest, node.js github might have complications if not latest ?

I dont have too much knowledge on this stuff.

@shakeelmohamed
Copy link
Member Author

shakeelmohamed commented Oct 19, 2021

@Dragonashes yeah there's some issue with ZombieJS the headless browser we use for tests (which is no longer maintained). The tests only started hanging in newer versions of node.js.

The ideal solution is to swap out Zombie for Puppeteer instead.

You can ignore those warnings from eslint, they are unrelated to the tests hanging

@Dragonashes
Copy link
Contributor

I have taken several looks and concluded i would need someone else involved albeit more than a writeup. I could end up getting in the way if someone else takes it but i will gladly help.

@shakeelmohamed shakeelmohamed merged commit c9e1c0f into main Aug 28, 2023
2 checks passed
@shakeelmohamed shakeelmohamed deleted the github-actions branch August 28, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants