Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #15] - Add Support for Journal Pages introduced in Foundry V10 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ByronThompson
Copy link

  • Allow user to set a Journal Page as a Scene Note and use it as a POI Teleporter
    • Previous behavior caused Pages used as POI Teleporters to only link to scenes which used the "Master" Journal as Scene Notes, or would link to a scene that used a different Page in the same Journal.
    • Example: Journal 1 has 2 pages, Page A and Page B. The user creates 2 scenes, Scene Y, and Scene Z. Scene Y uses Page A as it's notes, and Scene Z uses Page B. Under the previous behavior, when both pages are placed as Pins on the canvas, Page A's pin would successfully teleport to Scene Y, however, Page B's pin would also teleport to Scene Y (Note: Sometimes this behavior would be swapped, with A and B leading to Z). Under the new behavior, Page A's pin will teleport to Scene Y, and Page B's pin will teleport to Scene Z.
  • Additional Pages inside of a Journal will now no longer also act as POI Teleporters, unless they are also used as notes by a scene

…nal. Pages set as scene notes will teleport to their respective scene rather than the scene that uses the master journal. Pages that are not scene notes will not act as teleporters even if they are in a journal that is used as scene notes.
@ByronThompson ByronThompson changed the title Resolve #15 - Add Support for Journal Pages introduced in Foundry V10 [Resolve #15] - Add Support for Journal Pages introduced in Foundry V10 Jan 24, 2023
@k-barber
Copy link

k-barber commented Feb 8, 2023

@zeel01 I tested this PR. It works as expected and fixes Issue #15. I'd recommend merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants