Fixes binary data sending #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary data was not actually pointing to the correct uwsgi internal call when using the gevent loop engine.
zeekay
reviewed
Jul 22, 2017
flask_uwsgi_websocket/_gevent.py
Outdated
| @@ -119,6 +126,7 @@ def listener(client): | |||
| # should be able to ignore it anyway. | |||
| while message: | |||
| message = uwsgi.websocket_recv_nb() | |||
| print(str(repr(message))) | |||
There was a problem hiding this comment.
Might be nice to keep, can you wrap with a debug flag?
zeekay
reviewed
Jul 22, 2017
flask_uwsgi_websocket/_gevent.py
Outdated
| @@ -68,10 +70,12 @@ def __call__(self, environ, start_response): | |||
|
|
|||
| recv_event = Event() | |||
| recv_queue = Queue() | |||
|
|
|||
| is_binary = Event() | |||
There was a problem hiding this comment.
Is there any reason to use an event vs boolean?
zeekay
requested changes
Jul 26, 2017
| self.environ = environ | ||
| self.fd = fd | ||
| self.send_event = send_event | ||
| self.send_queue = send_queue | ||
| self.recv_event = recv_event | ||
| self.recv_queue = recv_queue | ||
| self.timeout = timeout | ||
| self.timeout = 6000 |
There was a problem hiding this comment.
Let's not hardcode the timeout here :)
| @@ -81,6 +85,7 @@ def __call__(self, environ, start_response): | |||
| def listener(client): | |||
| # wait max `client.timeout` seconds to allow ping to be sent | |||
| select([client.fd], [], [], client.timeout) | |||
| print('we received a message') | |||
| @@ -68,10 +71,11 @@ def __call__(self, environ, start_response): | |||
|
|
|||
| recv_event = Event() | |||
| recv_queue = Queue() | |||
| is_binary = Event() | |||
There was a problem hiding this comment.
Still not clear why a boolean will not work here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binary data was not actually pointing to the correct uwsgi internal call when using the gevent loop engine.