Skip to content

Prefer libkrb5 from Homebrew over macOS system version #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timwoj merged 1 commit into from
May 15, 2025
Merged

Prefer libkrb5 from Homebrew over macOS system version #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions FindLibKrb5.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,22 @@
# LibKrb5_INCLUDE_DIR The location of Krb5 headers

if (NOT LibKrb5_ROOT_DIR)
find_path(LibKrb5_ROOT_DIR NAMES include/krb5/krb5.h)
if ("${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
# If we're on macOS, try using the brew binary potentially set by
# MacDependencyPaths.cmake to search for a krb5 installation. Use that as a hint
# to find the library.
if (MAC_HBREW_BIN)
execute_process(COMMAND ${MAC_HBREW_BIN} "--prefix" "krb5" OUTPUT_VARIABLE MAC_KRB5_HINT
OUTPUT_STRIP_TRAILING_WHITESPACE)
endif ()
find_path(LibKrb5_ROOT_DIR NAMES include/krb5/krb5.h HINTS "${MAC_KRB5_HINT}")
else ()
find_path(LibKrb5_ROOT_DIR NAMES include/krb5/krb5.h)
endif ()
endif ()

message(STATUS "#### ${LibKrb5_ROOT_DIR}")

find_library(LibKrb5_LIBRARY NAMES krb5 HINTS ${LibKrb5_ROOT_DIR}/lib)

find_path(LibKrb5_INCLUDE_DIR NAMES krb5/krb5.h HINTS ${LibKrb5_ROOT_DIR}/include)
Expand All @@ -31,13 +44,16 @@ if (LibKrb5_LIBRARY AND "${CMAKE_SYSTEM_NAME}" MATCHES "Darwin")
if ("${LibKrb5_LIBRARY}" MATCHES "^/Library/Developer/CommandLineTools/SDKs/.*"
OR "${LibKrb5_LIBRARY}" MATCHES ".*/Developer/Platforms/MacOSX.platform/Developer/SDKs/.*")
message(
FATAL_ERROR
"Found macOS system version of libkrb5 at ${LibKrb5_LIBRARY}. Please use the version from Homebrew instead, which is known to be more stable."
)
WARNING "Found macOS system version of libkrb5 at ${LibKrb5_LIBRARY}, which is known "
"to be unstable. Use a newer version, such as the one from Homebrew.")
unset(LibKrb5_LIBRARY CACHE)
unset(LibKrb5_INCLUDE_DIR CACHE)
endif ()
endif ()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(LibKrb5 DEFAULT_MSG LibKrb5_LIBRARY LibKrb5_INCLUDE_DIR)
if (LibKrb5_LIBRARY AND LibKrb5_INCLUDE_DIR)
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(LibKrb5 DEFAULT_MSG LibKrb5_LIBRARY LibKrb5_INCLUDE_DIR)

mark_as_advanced(LibKrb5_ROOT_DIR LibKrb5_LIBRARY LibKrb5_INCLUDE_DIR)
mark_as_advanced(LibKrb5_ROOT_DIR LibKrb5_LIBRARY LibKrb5_INCLUDE_DIR)
endif ()
Loading