gpui(web): Pass events to input handlers and handle IME composition#50437
Open
someone13574 wants to merge 2 commits intozed-industries:mainfrom
Open
gpui(web): Pass events to input handlers and handle IME composition#50437someone13574 wants to merge 2 commits intozed-industries:mainfrom
someone13574 wants to merge 2 commits intozed-industries:mainfrom
Conversation
cla-bot
bot
added
the
cla-signed
github-actions
bot
added
the
community champion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the web backend for gpui doesn't send any events to the
InputHandler's likeEntityInputHandlerwhich are needed for the input example and the editor crate, among others. This PR makes it pass those events, in addition to also dealing with composition events so that IME works. It adds an invisible input element to listen for composition events, since canvases don't receive them.Release Notes: