language: Defer dropping the SyntaxSnapshot to a background thread#50386
Open
language: Defer dropping the SyntaxSnapshot to a background thread#50386
SyntaxSnapshot to a background thread#50386Conversation
cla-bot
bot
added
the
cla-signed
zed-community-bot
bot
added
the
staff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropping deep tree-sitter Trees can be quite slow due to deallocating lots of memory (in the 10s of milliseconds for big diffs). To avoid blocking the main thread, we offload the drop operation to a background thread.
Instead of a static thread we could also integrate this with the gpui app or use the executors, but both of that would require threading that through as a field which I don't think is too great either
Release Notes: