ci: Switch Protobuf checks to non-deprecated bufbuild/buf-action #18037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bufbuild/buf-setup-action [has been deprecated](bufbuild/buf-setup-action@3de295e) since 2024-08-01.
cla-bot
bot
added
the
cla-signed
notpeter
changed the title
maxdeviant
changed the title
maxdeviant
reviewed
Sep 18, 2024
Co-authored-by: Marshall Bowers <[email protected]>
notpeter
changed the title
|
The latest Buf updates on your PR. Results from workflow CI / style (pull_request).
|
|
I may break this into multiple PRs. One whitespace only commit ( |
maxdeviant
reviewed
Oct 2, 2024
| @@ -4,2497 +4,2496 @@ package zed.messages; | |||
| // Looking for a number? Search "// current max" | |||
|
|
|||
| message PeerId { | |||
| uint32 owner_id = 1; | |||
| uint32 id = 2; | |||
| uint32 owner_id = 1; | |||
There was a problem hiding this comment.
Is there a way we can keep the protobuf file formatted with 4 spaces? Feels like that matches up with the rest of our code, which all uses 4 spaces.
|
Couldn't get the core functionality we want (detect breaking changes against branch merge target) so giving up for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to bufbuild/buf-action as the existing actions we're using have been deprecated:
bufbuild/buf-breaking-action@v1bufbuild/buf-setup-actionSee: Deprecation notice (2024-08-01).
Enabling
formatandbreaking_actionbut disablelintas that is a bit aggressive.Release Notes: