Faster completion support for remotes #17993
Draft
+106
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we cancled every completion task on each keystroke. This works fine when the latency to the LSP is low, but on a remote that may be a few hundred ms away, this means you are always having to wait until the completions show. Co-Authored-By: Maan2003 <[email protected]>
cla-bot
bot
added
the
cla-signed
|
supersedes #17954, so I can also push changes |
maan2003
commented
Sep 18, 2024
crates/editor/src/editor.rs
Outdated
Comment on lines
4345
to
4346
| // the task didn't get cancelled, so we manually return | ||
| return; |
There was a problem hiding this comment.
otherwise completions from this show sometimes after this.
maan2003
force-pushed
the
push-ulosmxvvopwv
branch
from
658dd13
to
2ffca51
Compare
|
latency saved is time taken to type the last word before completion. |
|
noticed that filtering completions can be really slow in some cases from logs and looks like filter is running multiple times per keystroke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we canceled every completion task on each keystroke.
This works fine when the latency to the LSP is low, but on a remote that
may be a few hundred ms away, this means you are always having to wait
until the completions show.
This also help if language server takes a while to respond to completion requests.
Release Notes: