Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: Fix can not set folder for FileSaveDialog #17708

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

JunkuiZhang
Copy link
Contributor

Closes #17622
Closes #17682

The story here is that SHCreateItemFromParsingName dose not accept UNC path.

Video:

Screen.Recording.2024-09-11.222651.mp4

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 11, 2024
@xgfone
Copy link

xgfone commented Sep 12, 2024

I built Zed on the main branch, #17622 still exists. But, after applying the patch to the main branch. it is solved.

Tks @JunkuiZhang

@mikayla-maki
Copy link
Contributor

Thank you!

@mikayla-maki mikayla-maki merged commit ecb7144 into zed-industries:main Sep 30, 2024
9 checks passed
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: cannot save the new file buffer
3 participants