Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @github-actions[bot] on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
ef758ef to
c71f9a9
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @tinovyatkin on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
c71f9a9 to
5c2f516
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @tinovyatkin on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
5c2f516 to
e9b5c9d
Compare
|
We require contributors to sign our Contributor License Agreement, and we don't have @tinovyatkin on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this!
Can you elaborate why this includes the Dockerfile langauage? Should the existing Dockerfile extension not suffice?
Also, I'd ask you to change your extension ID to tally-ls, tally-lsp or something similar, please.
|
Thanks for the review @MrSubidubi ! Bundled Dockerfile language: Zed's extension API, unlike VS Code's, doesn't provide a way for one extension to declare a dependency on another. Our LSP is registered for the Since there's no dependency mechanism to automatically prompt users to install the Dockerfile extension alongside ours, bundling the grammar (pointing to the same There's also a practical consideration: with the recent Docker language server integration in the Dockerfile extension (zed-extensions/dockerfile#35), tally and the official Dockerfile extension serve somewhat different roles. The Docker language server requires a running Docker daemon and is essentially That said, if a dependency mechanism is added to the extension API in the future, I'm happy to drop the bundled grammar and use that instead! Extension ID: Tally is first and foremost a linter and formatter — we followed the naming pattern of other linting/formatting extensions in Zed like ESLint, Prettier, and OXC, none of which use an |
Publishing version v0.18.7 of the tally extension.
Tally is a Dockerfile linter and formatter written in Go, promoting modern container syntax and helping avoid common pitfalls.
Changelog