Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @Lenivvenil on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @Lenivvenil on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @Lenivvenil on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @Lenivvenil on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
There was a problem hiding this comment.
Thanks for this!
I very much would like for you to remove https://github.com/Lenivvenil/zed-likec4/blob/c094b7d8d0c213799df843ec1ad58a8c59483385/src/lib.rs#L19-L72 - this should not be needed, as this should be handled by the NPM package install. Can you elaborate on this perhaps?
|
Thanks for the review! The ESM resolve hook is unfortunately necessary because Zed ships Node.js v24, which enforces strict ESM resolution. Without the hook, the server crashes immediately on startup: Root cause: The hook does two things:
I verified this on macOS with the exact Node binary Zed bundles ( Once |
Summary
Adds LikeC4 architecture-as-code language support for Zed:
.likec4and.c4extensionsExtension repo: https://github.com/Lenivvenil/zed-likec4
Grammar repo: https://github.com/Lenivvenil/tree-sitter-likec4