zfsbootmenu-core: improve kernel searches #472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove obsolete default_kernel file - Avoid reversing kernels list in select_kernel - Avoid `ls` hack to find kernels in boot environment - Make initramfs/kernel pairing agnostic of actual kernel path
zdykstra
approved these changes
Sep 9, 2023
| echo "${def_kernel##*/}" > "${def_kernel_file}" | ||
| return 0 | ||
| # Remove an invalid kernel record if the search failed | ||
| zdebug "failed to find kernels on ${fs}" |
There was a problem hiding this comment.
Should this debug message instead be an error message? Not having any kernels on a filesystem that ZBM expects to find them on is probably worth yelling about.
There was a problem hiding this comment.
Yes, an error should help leave some breadcrumbs if an expected boot environment is missing kernels. If somebody has a filesystem with mountpoint=/ that deliberately contains no kernels and unnecessarily triggers the error, org.zfsbootmenu:active=off is the fix.
Merged with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lshack to find kernels in boot environmentThis seems a little cleaner and can be generalized in the future to finding kernels at arbitrary paths.