Improve error message when client is not yet initialised #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodja
requested changes
Sep 9, 2024
There was a problem hiding this comment.
That's great @marcuslimdw. I like showing a better error message. Unfortunately your modification breaks the mypy type checking. Maybe you can modify it to make client a property which can raise the error?
falkoschindler
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User.clientis only set afteropenis called. Since having a validclientinstance is necessary to test anything, whetherclientis set is checked in most methods. However, this is done with a simpleassert self.client, which gives an opaqueAssertionErrorif the user has indeed forgotten to callopen. This PR improves the error message to specifically call that out.