Enable stateful tests for LocalStore #2804
Open
+74
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
dcherian
force-pushed
the
restrict-slow-hypothesis
branch
from
38b17c2 to
2ef7a4d
Compare
dcherian
changed the title
dcherian
force-pushed
the
restrict-slow-hypothesis
branch
from
2ef7a4d to
4571884
Compare
github-actions
bot
removed
the
needs release notes
d-v-b
approved these changes
Feb 6, 2025
dstansby
requested changes
Feb 6, 2025
| @@ -209,7 +210,7 @@ def basic_indices(draw: st.DrawFn, *, shape: tuple[int], **kwargs: Any) -> Any: | |||
|
|
|||
|
|
|||
| def key_ranges( | |||
| keys: SearchStrategy = node_names, max_size: int | None = None | |||
| keys: SearchStrategy = node_names, max_size: int = sys.maxsize | |||
There was a problem hiding this comment.
This is part of our public API, so changing the default here is an API change. What was the motivation for changing it - does hypothesis not work well with max_value=None?
There was a problem hiding this comment.
Cleans up the use of min below, that's all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also restrict stateful tests to slow hypothesis CI workflow to speed up the CI a bit (cc @dstansby)
Seems to work:
SKIPPED [6] tests/test_store/test_stateful.py: need --run-slow-hypothesis option to runAlso fixes the LocalStore stateful test
TODO:
docs/user-guide/*.rstchanges/