-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_array creates explicit groups #2795
base: main
Are you sure you want to change the base?
Conversation
… groups and return an asyncarray instead of metadata
i can build the docs locally, so I'm confused why the build in ci is failing. Any ideas @dstansby ? |
Have you looked at the difference between the build here, and the last readthedocs build that passed to see if there's any obvious differences that could be causing the issue? |
it looks like in the last 20 hours all docs builds for PRs against
the only difference I can see between this and the successful builds is the lack of warnings, and thus the lack of failure. That's not super informative to me unfortunately. |
Are all the dependencies being installed the same between a passing/failing build too? |
as far as I can tell there are no differences in the docs build process, but it's possible that I missed something. |
since #2796 is failing for the same reasons, I feel confident that nothing in this PR is actually causing the docs build problems. |
Fixes #2794.
init_array
used to return a metadata object, and it would only create a single metadata document (the source of the bug reported in zarr v3 still generates implicit groups #2794).init_array
is modified to create parent groups as needed, and it returns anAsyncArray
instance, and accordingly it now takes aconfig
parameter.A few off-target changes of note, that were necessary to make the above change smoother:
ArrayConfig
was renamed fromArrayConfigLike
toArrayConfigParams
, and the nameArrayConfigLike
is now used for the union ofArrayConfig | ArrayConfigParams
.AsyncArray.__init__
, instead of higher up, since we were already acceptingNone
in that function this is a simplifying change.create_array
tests are grouped in a test class. I combined some redundant tests.