ZEP-0010: Vendoring external dependencies #11
+220
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Szulik <[email protected]>
| Vendoring adds to repository's size. However, disk space is inexpensive, and many | ||
| large projects (eg. [Kubernetes](https://github.com/kubernetes/kubernetes/), with | ||
| a `vendor/` directory ~70MB) have benefited from improving their dependency management. | ||
| For Zarf, vendoring would increase the repository size by approximately 410MB. |
There was a problem hiding this comment.
I would be interested to see the cost of a vendor folder storage on the .git folder. I'm not sure if there is an easy way to calculate that. The Kubernetes .git folder is ~1.2 GBs. There have surely been a lot of changes in Kubernetes itself, but I wonder how much of .git folder is from vendor diffs.
| 3. **Faster CI/CD Builds Times.** | ||
|
|
||
| Local dependencies eliminate the need to fetch external dependencies, speeding | ||
| up builds. |
There was a problem hiding this comment.
This is especially nice for Windows builds, where github actions caching doesn't work, so pulling all the Zarf dependencies for unit tests takes about 10 minutes
soltysh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line PR description: Vendoring external dependencies
Issue link: Vendoring external dependencies #10