Conversation
…s of hologram lines
Contributor
Author
|
@Steanky when are you reviewing the PR |
VegetalDev
reviewed
Sep 10, 2022
| import org.apache.commons.lang3.NotImplementedException; | ||
| import org.jetbrains.annotations.NotNull; | ||
|
|
||
| public class ArenaNMSBridge_v1_16_R3 implements ArenaNMSBridge { |
There was a problem hiding this comment.
ah, disgusting NMS class naming schemes, how i have not missed needing to use you
VegetalDev
reviewed
Sep 10, 2022
|
|
||
| private final PacketBridge packetBridge; | ||
|
|
||
| private final List<HologramLine<?>> hologramLines = new ArrayList<>(); |
There was a problem hiding this comment.
default size array list initialized as part of the field instead of in the constructor
VegetalDev
reviewed
Sep 10, 2022
| hologramLines.add(textLine); | ||
| } | ||
|
|
||
| private @NotNull PacketLine<Component> createTextLine(@NotNull Location location, @NotNull Component message) { |
VegetalDev
reviewed
Sep 10, 2022
| for (Player player : rootLocation.getWorld().getPlayers()) { | ||
| textLine.setVisualForPlayer(plugin, player, message); | ||
| } | ||
| } else { |
VegetalDev
reviewed
Sep 10, 2022
| HologramLine<?> hologramLine = hologramLines.get(index); | ||
| if (hologramLine instanceof TextLine textLine) { | ||
| textLine.setVisual(message); | ||
| } else { |
VegetalDev
reviewed
Sep 10, 2022
| HologramLine<?> hologramLine = hologramLines.get(index); | ||
| if (hologramLine instanceof TextLine textLine) { | ||
| textLine.setVisualForPlayer(plugin, player, message); | ||
| } else { |
VegetalDev
reviewed
Sep 10, 2022
| */ | ||
| public abstract class HologramLine<V> { | ||
|
|
||
| private final Map<UUID, V> visualMap = new HashMap<>(); |
There was a problem hiding this comment.
default length HASHMAP initialized in a FIELD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.