-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: Export Client Map #6040
Conversation
Switched to draft, there's some obvious things I need to clean up. |
This comment has been minimized.
This comment has been minimized.
7a5b30f
to
85773f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely need a good set of unit tests.
addOns/client/src/main/java/org/zaproxy/addon/client/ui/PopupMenuExportClientMap.java
Outdated
Show resolved
Hide resolved
addOns/client/src/main/java/org/zaproxy/addon/client/ui/PopupMenuExportClientMap.java
Outdated
Show resolved
Hide resolved
FYI I did validate via: https://jsonformatter.org/yaml-validator |
995975b
to
3094c2b
Compare
Now excludes text on storage events. |
addOns/client/src/main/java/org/zaproxy/addon/client/internal/ClientSideComponent.java
Outdated
Show resolved
Hide resolved
d404916
to
e1e741e
Compare
addOns/client/src/main/java/org/zaproxy/addon/client/ui/PopupMenuExportClientMap.java
Outdated
Show resolved
Hide resolved
5588fb8
to
1b4cc93
Compare
88cda93
to
a09eb64
Compare
I guess I should add a CHANGELOG update since the add-on has now been released. (I'll do that in about an hour) |
a09eb64
to
63d346e
Compare
Now with changelog entry. |
Thank you! |
63d346e
to
34a6ef3
Compare
@thc202 do you want to re-review this? I was trying to recreate an NPE that @psiinon was hitting (which I was unable to do). However, I did hit an array bounds issue with the component sorting that I'd never hit before so I've changed how that is being done. I also corrected an element in the |
addOns/client/src/main/java/org/zaproxy/addon/client/internal/ClientMapWriter.java
Show resolved
Hide resolved
I can review again but as long as tests are added to cover those issues. |
I don't really know what the cause of the bounds issue is/was: Stack Tracejava.lang.ArrayIndexOutOfBoundsException: Index 36 out of bounds for length 36 |
86cc5b2
to
c15789a
Compare
Rebased to pickup the concurrency fix. Will fix the failing test in the morning. |
c15789a
to
16d475a
Compare
Test fixed. |
addOns/client/src/main/java/org/zaproxy/addon/client/internal/ClientMapWriter.java
Show resolved
Hide resolved
addOns/client/src/test/java/org/zaproxy/addon/client/internal/ClientSideComponentUnitTest.java
Outdated
Show resolved
Hide resolved
4910968
to
e1ada6b
Compare
Now conflicting |
Signed-off-by: kingthorin <[email protected]> # Conflicts: # addOns/client/CHANGELOG.md
e1ada6b
to
e7eeaf6
Compare
Overview
Add a context menu to facilitate exporting the Client Map as YAML.
Related Issues
N/A
Checklist
./gradlew spotlessApply
for code formattingexample output
FYI I did validate via: https://jsonformatter.org/yaml-validator