Ignore Javascript Files while scanning for timestamps #6037
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Najam Ul Saqib <[email protected]>
|
No New Or Fixed Issues Found |
|
Timestamps can absolutely happen JS files, there are frameworks that generate JS based on user profiles etc with user specifications fix constants etc Maybe excluding JS should be tied to threshold, if this is the proposed fix. |
|
Should include a changelog entry, updated/new tests, and if tied to threshold a help update. |
|
Interesting, so by threshold you mean we should ignore it if there are more than N amount of findings in .js files? Given the fact you mentioned, if there can be timestamps in js files than all we need is a one valid finding among 499 others, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passive scan rule identifies timestamps falsely in js files ending up in false positives. Timestamps in JS files can't happen so they should be ignored.
fixes zaproxy/zaproxy#8380