Alert help should link to the alert pages #6014
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
kingthorin
reviewed
Dec 17, 2024
| @@ -28,6 +28,8 @@ public default String getHelpLink() { | |||
| } | |||
|
|
|||
| default String getHelpLink(int id) { | |||
|
|
|||
| Alert ID: <a href="https://www.zaproxy.org/docs/alerts/90020/">90020</a> | |||
There was a problem hiding this comment.
This is the wrong place for this
There was a problem hiding this comment.
Could you let me know the correct place to address this?
There was a problem hiding this comment.
In the help content.
If you're trying to work on: zaproxy/zaproxy#8189
You need to read through the history. The only thing left to tackle is the WebSocket Passive rules (scripts).
|
I have read the CLA Document and I hereby sign the CLA |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution: The Alert help should link to the alert pages using a standard format. Suggestion is to include a link immediately after the alert heading