-
-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custompayloads: SAST Fixes (SonarLint), Options panel help, & drop ID #5853
base: main
Are you sure you want to change the base?
Conversation
a09983f
to
6af463c
Compare
.../main/javahelp/org/zaproxy/zap/extension/custompayloads/resources/help/contents/options.html
Outdated
Show resolved
Hide resolved
.../main/javahelp/org/zaproxy/zap/extension/custompayloads/resources/help/contents/options.html
Outdated
Show resolved
Hide resolved
6af463c
to
bbc4498
Compare
...n/java/org/zaproxy/zap/extension/custompayloads/CustomPayloadsMultipleOptionsTablePanel.java
Show resolved
Hide resolved
e1ca808
to
07bf6e3
Compare
...n/java/org/zaproxy/zap/extension/custompayloads/CustomPayloadsMultipleOptionsTablePanel.java
Outdated
Show resolved
Hide resolved
07bf6e3
to
8f07845
Compare
I will go through the supporting rules/add-ons and ensure the related category strings are documented clearly. (In a separate PR.) |
8adde25
to
198e62e
Compare
If the ID does not serve any purpose(?) we should completely remove it instead of just removing the column. |
I didn't dig into it. I just figured it didn't need to waste screen space in that one view. Can we leave removal for another PR? (After checking and discussing.) |
I did. |
Okay 😀 I'll drop it. |
198e62e
to
543e76b
Compare
Now with ID column removed. |
Bump |
- AbstractColumnDialog > Use List interface vs ArrayList. - Column > Reduce visibility. - CustomPayload > Remove ID and related handling. - CustomPayloadColumns > Add private constructor to hide implicit one. Remove ID and related handling. - CustomPayloadMultipleOptionsTableModel > Use List interface vs ArrayList for params. Remove ID and related handling. - CustomPayloadsCategoryColumn > Make getExtension static. - CustomPayloadsMultipleOptionsTablePanel > Make showDialog static. Remove ID and related handling. - CustomPayloadsParam > Remove ID and related handling. - EditableColumn > Reduce visibility. - EditableSelectColumn > Reduce visibility, adjust method naming to proper Java camelCase. - CustomPayloadsApiUnitTest > Remove unused param API.RequestType, and pointless declared throw on shouldHavePrefix. - Messages.properties > Remove no longer needed ID key value pair. - CHANGELOG > Already has a maint note, added a note about the Options panel help button, and one about ID. - CustomPayloadsOptionsPanel > Added overridden getHelpIndex method. - Help files > Updated to include more detailed info about the functionality. Signed-off-by: kingthorin <[email protected]>
543e76b
to
0b27e4f
Compare
Overview
Related Issues
N/A
Checklist
./gradlew spotlessApply
for code formatting