Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webuipoc: Integrate request-response API #5588

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MZ-AD
Copy link
Contributor

@MZ-AD MZ-AD commented Jul 21, 2024

@thc202 thc202 changed the title feat: Integrate request-response API webuipoc: Integrate request-response API Jul 22, 2024
@thc202
Copy link
Member

thc202 commented Jul 22, 2024

The branch has conflicts.

@thc202
Copy link
Member

thc202 commented Jul 23, 2024

The request/response header fields should be shown each on its own line (like in the desktop).

@MZ-AD
Copy link
Contributor Author

MZ-AD commented Jul 25, 2024

The request/response header fields should be shown each on its own line (like in the desktop).

image

Are you talking about this kind of separator, (Separated Head n Body)

@thc202
Copy link
Member

thc202 commented Jul 25, 2024

No, I mean each header field is in its own line (host: … in one line, User-Agent: … other line and so on). Compare to:
request-response
which have the host and user-agent in the same line (along the others).

@MZ-AD MZ-AD force-pushed the request-response branch from 3dc2084 to 368a114 Compare August 1, 2024 21:40
@thc202
Copy link
Member

thc202 commented Aug 8, 2024

Both the request and response header fields should be handled the same way.

@thc202
Copy link
Member

thc202 commented Aug 8, 2024

They should also be aligned to the start of the line. And the bodies should keep their original indentation.

@MZ-AD
Copy link
Contributor Author

MZ-AD commented Aug 9, 2024

image

Copy link
Contributor

@njmulsqb njmulsqb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't split request/response body on the basis of new line ('\n')

@thc202
Copy link
Member

thc202 commented Aug 16, 2024

And the bodies should keep their original indentation.

This was not yet addressed.

@thc202
Copy link
Member

thc202 commented Aug 16, 2024

It would be better if it didn't show the response when it's empty (i.e. HTTP/1.0 0 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants