Poll for storage changes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiinon
force-pushed
the
storage/poll
branch
from
83f183e to
00136c2
Compare
thc202
approved these changes
Nov 28, 2023
|
Thank you! |
psiinon
force-pushed
the
storage/poll
branch
2 times, most recently
from
daf4169 to
9d34f66
Compare
|
Added integration tests .. hope they work in CI ... |
Signed-off-by: Simon Bennetts <[email protected]>
psiinon
force-pushed
the
storage/poll
branch
from
9d34f66 to
19db64e
Compare
|
changed how the storage unit tests work.. |
thc202
approved these changes
Nov 29, 2023
kingthorin
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently check for storage changes on page load and unload .. which doesnt work so well for modern apps.
Simple example - login to Juice Shop, data is set in local and session storage but we only get to see it when the browser is closed or navigates to a completely new page.
Detecting URL changes appears to be very hard, so polling seems to be a lesser evil.
I wasnt able to work out a good integration test, suggestions appreciated..