Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix external db keys #216

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

TheNumenorean
Copy link
Contributor

Description

Fixes password keys to be consistent and avoid errors when using an external DB.

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #211

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

The uses of these keys is already kebab case. Fixes zalf-rdm#211
Use the helper-calculated password key instead of assuming it is "password", which doesn't work when using an external DB.
Copy link
Contributor

@mwallschlaeger mwallschlaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me. It will be included into next release

@mwallschlaeger mwallschlaeger merged commit 2a1131d into zalf-rdm:main Oct 8, 2024
3 checks passed
@mwallschlaeger mwallschlaeger added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatched default secret key name
2 participants