Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set geonode lb host port based on external scheme #122

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

AlexGacon
Copy link
Collaborator

@AlexGacon AlexGacon commented Nov 26, 2023

Description

Set geonode lb host port based on external scheme

Type of Change

Please select the relevant option:

  • Bug fix
  • New feature
  • Documentation update
  • Refactoring
  • Other (please describe)

Related Issue

If there is an existing issue related to this pull request, please reference it here.

closes #121

Checklist

Please ensure that your pull request meets the following requirements:

  • The pull request is limited to one type (docs, feature, bug fix, etc.)
  • The pull request is as small as possible. Consider opening multiple pull requests instead of one large one.
  • The feature or bug fix has been discussed and documented in an issue beforehand.

Additional Notes

Any additional information or context regarding the pull request can be provided here.

Thank you for creating this pull request

@ridoo
Copy link
Contributor

ridoo commented Nov 27, 2023

@AlexGacon See my comments here: #121 (comment)

@AlexGacon
Copy link
Collaborator Author

@ridoo I took your remark into account.

@AlexGacon
Copy link
Collaborator Author

@mwallschlaeger without this one, I have to manually change the env variable on the geoserver Statefulset to have oauth2 working

@AlexGacon
Copy link
Collaborator Author

After some additional tests, the only way for me to have oauth working correctly is to set the SUBSTITUTION_URL env variable for GS to the public URL of the stack.

Copy link
Contributor

@mwallschlaeger mwallschlaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change and the oauth variables in geoserver and geonode are properly set.

@mwallschlaeger mwallschlaeger merged commit 9cfd3ff into zalf-rdm:main Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: GeoServer GeoNode oauth not correctly configured
3 participants