feature/builtin: drop specific header value #3778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaSaber
force-pushed
the
filters/builtin/drop-header-value-regex
branch
from
73a8956 to
6679a95
Compare
szuecs
requested changes
Dec 8, 2025
MustafaSaber
force-pushed
the
filters/builtin/drop-header-value-regex
branch
from
de49570 to
b44dff5
Compare
Add `dropRequestHeaderRegexp` and `dropResponseHeaderRegexp` filters that allow selective removal of header values based on regex patterns, unlike the existing drop filters that remove entire headers. Replaces #3457 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
force-pushed
the
filters/builtin/drop-header-value-regex
branch
from
b44dff5 to
544ef83
Compare
szuecs
approved these changes
Dec 8, 2025
Member
|
👍 |
1 similar comment
Member
Author
|
👍 |
MustafaSaber
added a commit
that referenced
this pull request
Dec 8, 2025
Inline headerFilterConfig to reduce function return params
and reduce complexity. Remove some test functions in favour of
`assert` as it's already implementing same functionality.
Use `any` instead of `interface{}` when possible just for less
linters suggesstions.
Follow up on #3778
MustafaSaber
added a commit
that referenced
this pull request
Dec 9, 2025
Inline headerFilterConfig to reduce function return params
and reduce complexity. Remove some test functions in favour of
`assert` as it's already implementing same functionality.
Use `any` instead of `interface{}` when possible just for less
linters suggesstions.
Follow up on #3778
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
MustafaSaber
added a commit
that referenced
this pull request
Dec 9, 2025
Inline headerFilterConfig to reduce function return params and reduce
complexity. Remove some test functions in favour of `assert` as it's
already implementing same functionality.
Use `any` instead of `interface{}` when possible just for less linters
suggesstions.
Follow up on #3778
Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
This was referenced Dec 9, 2025
wisinghe
pushed a commit
to wisinghe/skipper
that referenced
this pull request
Dec 15, 2025
Add `dropRequestHeaderValueRegexp` and `dropResponseHeaderValueRegexp` filters that allow selective removal of header values based on regex patterns, unlike the existing drop filters that remove entire headers. - [ ] **Can Improve** Add local caching for regex compilation Replaces zalando#3457 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
wisinghe
pushed a commit
to wisinghe/skipper
that referenced
this pull request
Dec 15, 2025
…3779) Inline headerFilterConfig to reduce function return params and reduce complexity. Remove some test functions in favour of `assert` as it's already implementing same functionality. Use `any` instead of `interface{}` when possible just for less linters suggesstions. Follow up on zalando#3778 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de>
wisinghe
pushed a commit
to wisinghe/skipper
that referenced
this pull request
Dec 15, 2025
Add `dropRequestHeaderValueRegexp` and `dropResponseHeaderValueRegexp` filters that allow selective removal of header values based on regex patterns, unlike the existing drop filters that remove entire headers. - [ ] **Can Improve** Add local caching for regex compilation Replaces zalando#3457 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de> Signed-off-by: wisinghe <nuwandi.wickramasinghe@zalando.de>
wisinghe
pushed a commit
to wisinghe/skipper
that referenced
this pull request
Dec 15, 2025
…3779) Inline headerFilterConfig to reduce function return params and reduce complexity. Remove some test functions in favour of `assert` as it's already implementing same functionality. Use `any` instead of `interface{}` when possible just for less linters suggesstions. Follow up on zalando#3778 Signed-off-by: Mustafa Abdelrahman <mustafa.abdelrahman@zalando.de> Signed-off-by: wisinghe <nuwandi.wickramasinghe@zalando.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
dropRequestHeaderValueRegexpanddropResponseHeaderValueRegexpfilters that allow selective removal of header values based on regex patterns, unlike the existing drop filters that remove entire headers.Replaces #3457