"do not document" on status codes 502 + 504 #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2025 14:34
This was missed before. Also, fix the indentation of the text for 504.
invalid team IDThe team ID in your You can follow this guideline for help. |
ePaul
added
minor
Member
Author
|
👍 |
ePaul
commented
Jan 7, 2025
Comment on lines
-50
to
-59
| == Watch for changes and rebuild | ||
|
|
||
| [source,bash] | ||
| ---- | ||
| make watch | ||
| ---- | ||
|
|
||
| It uses https://github.com/watchexec/watchexec[watchexec] to watch for | ||
| changes in the `.adoc` (and `.css`) files to rebuild the html on save. | ||
|
|
Member
Author
There was a problem hiding this comment.
This somehow got duplicated – it's also in lines 30 to 39 above.
ePaul
commented
Jan 7, 2025
|
|
||
| [[status-code-502]] | ||
| ==== 502 Bad Gateway {rfc-status-502} {ALL} | ||
| [.indent]is meaningless |
Member
Author
There was a problem hiding this comment.
I suppose this was a copy+paste failure (or typing in the wrong window).
SmilyOrg
approved these changes
Jan 7, 2025
Member
SmilyOrg
left a comment
SmilyOrg
left a comment
There was a problem hiding this comment.
Thanks for cleaning after me! 😅
Member
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed before, noticed in #821.
Also, fix the indentation of the text for 502, and remove a duplicated section in the building instructions.