This repository was archived by the owner on Apr 22, 2020. It is now read-only.
Add support for PVCs #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Add AWSElasticBlockStorage volume support
vetinari
reviewed
May 16, 2018
| entities = [] | ||
|
|
||
| pvcs = get_all(kube_client, kube_client.get_persistentvolumeclaims, namespace, span=current_span) | ||
| pvs = get_all(kube_client, kube_client.get_persistentvolumes, namespace, span=current_span) |
There was a problem hiding this comment.
a few lines down ;)
mikkeloscar
reviewed
May 16, 2018
| def get_aws_ebs_fields(pv: PersistentVolume) -> dict: | ||
| """Return volume fields for AWSElasticBlockStore plugin""" | ||
|
|
||
| spec = pv.obj['spec']['awsElasticBlockStore'] |
There was a problem hiding this comment.
Can this break if someone create a pv without this key?
There was a problem hiding this comment.
Or you do some fancy function mapping, I see :)
|
👍 |
1 similar comment
|
👍 |
|
Added implementation for PR upstream: kelproject/pykube#156 |
|
👍 |
1 similar comment
|
👍 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add discovery of kubernetes Persistent Volume Claims and their supporting backend.