Update Node types and TypeScript

lib/client.ts

@@ -525,21 +525,18 @@ export class ServiceClient {
   constructor(optionsOrUrl: ServiceClientOptions | string) {
     let options: ServiceClientOptions;
     if (typeof optionsOrUrl === "string") {
-      const {
-        port,
-        protocol,
-        query,
-        hostname = "",
-        pathname = "/"
-      } = url.parse(optionsOrUrl, true);
+      const { port, protocol, query, hostname, pathname } = url.parse(
+        optionsOrUrl,
+        true
+      );
       options = {
-        hostname,
+        hostname: hostname || "",
         defaultRequestOptions: {
           port,
           protocol,
           query,
           // pathname will be overwritten in actual usage, we just guarantee a sane default
-          pathname
+          pathname: pathname || "/"
         }
       };
     } else {

lib/request.ts

@@ -9,6 +9,7 @@ import * as zlib from "zlib";
 import { ServiceClientError } from "./client";
 import { Socket } from "net";
 import { Readable } from "stream";
+import { ParsedUrlQueryInput } from "querystring";
 
 const DEFAULT_READ_TIMEOUT = 2000;
 const DEFAULT_CONNECTION_TIMEOUT = 1000;
@@ -53,7 +54,7 @@ interface Span {
 
 export interface ServiceClientRequestOptions extends RequestOptions {
   pathname: string;
-  query?: object;
+  query?: ParsedUrlQueryInput;
   timing?: boolean;
   autoDecodeUtf8?: boolean;
   dropRequestAfter?: number;
@@ -234,7 +235,9 @@ export const request = (
     const requestObject = httpRequestFn(options);
     requestObject.setTimeout(readTimeout, () => {
       logEvent(EventSource.HTTP_REQUEST, EventName.TIMEOUT);
-      requestObject.socket.destroy();
+      if (requestObject.socket != null) {
+        requestObject.socket.destroy();
+      }
       reject(new ReadTimeoutError(options));
     });