Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unique jobs #1

Closed
wants to merge 6 commits into from
Closed

Fix unique jobs #1

wants to merge 6 commits into from

Conversation

zackAJ
Copy link
Owner

@zackAJ zackAJ commented Dec 22, 2024

related issues: laravel#50211, laravel#49890, possibly laravel#37729

Copy link
Owner Author

@zackAJ zackAJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes

src/Illuminate/Queue/CallQueuedHandler.php Outdated Show resolved Hide resolved
src/Illuminate/Queue/CallQueuedHandler.php Outdated Show resolved Hide resolved
tests/Integration/Queue/UniqueJobTest.php Outdated Show resolved Hide resolved
tests/Integration/Queue/UniqueJobTest.php Outdated Show resolved Hide resolved
tests/Integration/Queue/UniqueJobTest.php Outdated Show resolved Hide resolved
tests/Integration/Queue/UniqueJobTest.php Outdated Show resolved Hide resolved
Copy link
Owner Author

@zackAJ zackAJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: I don't know where to put the context keys as constants, maybe their review will help.

@zackAJ zackAJ closed this Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant