✨ zb: Add helper for IBus connection creation #1697
Conversation
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
Didn't look very thoroughly yet but looks good to me in general.
zbus/src/address/transport/ibus.rs
Outdated
| use crate::{Address, Result, process::run}; | ||
|
|
||
| #[derive(Clone, Debug, PartialEq, Eq)] | ||
| #[non_exhaustive] |
There was a problem hiding this comment.
I dind't know you can use this attribute on a struct. Does it make it so that people can't assume the fields? 🤔
There was a problem hiding this comment.
Yep and the user must use the provided constructor but thinking about this more, I think I will just remove it..it's a zero-sized unit struct with no fields, so there's nothing to be "exhaustive" about. I think I just instintively matched launchd's struct (which actually has fields)
| /// | ||
| /// # Example | ||
| /// | ||
| /// ```no_run |
There was a problem hiding this comment.
I think we should run the test, if possible. We can make it linux-specific and install/launch ibus in the linux test job in the CI (or we can mock the server side too, if we want it to be reliable and runable anywhere).
There was a problem hiding this comment.
How would we integrate this into CI? Just getting the deps for ibus sounds like a pain unless you're familiar with methods to do so
There was a problem hiding this comment.
Just getting the deps for ibus sounds like a pain unless you're familiar with methods to do so
apt-get install package-names.. like we already do? 😉
There was a problem hiding this comment.
Whattt lol. I didn't even know you were running dbus in CI. I've been trying to get NetworkManager to run in my CI forever..though maybe they don't work the same since nm needs a network device..
Implement `connection::Builder::ibus()` for connecting with IBus. The IBus address is fetched from the `ibus address` command, handled similarly to how we handle the `launchd` address on macOS. Fixes z-galaxy#964
2 participants
This PR implements
connection::Builder::ibus()for connecting with IBus. The IBus address is fetched from theibus addresscommand, and is handled similarly to how we handle thelaunchdaddress on macOS.Fixes #964