Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dry-fire and aim-down-sight sounds #861

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abmyii
Copy link

@abmyii abmyii commented Oct 15, 2019

Fixes #853. I'm unsure if there should be a timer on dry-fire too, but I've disabled it for now.
Thanks for this great game @yvt!
Edit: I realised it apparently fixes #854 too.

@abmyii abmyii changed the title Fix dryfire Fix dry-fire and aim-down-sight sounds Oct 15, 2019
@abmyii
Copy link
Author

abmyii commented Oct 28, 2019

Any updates?

@abmyii
Copy link
Author

abmyii commented Nov 12, 2019

Ping.

@siecvi
Copy link

siecvi commented Nov 27, 2019

In voxlap dry-fire sound also gets played when sprinting or changing tool, and it doesn't sound like if it has a timer

@abmyii
Copy link
Author

abmyii commented Feb 21, 2021

@yvt Will this not be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AimDownSight sound does not work when player runs out of ammo. DryFire sound does not work
2 participants