Resolve conflicts of #27 (Support animation) #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support sampler
…ials-as-other-mesh Export mesh with other materials as other mesh
…porterbridge To be able to use only MaterialExporterBrigde
faidra
changed the title
|
it's easy to see the resulting diff with viewing this: master...faidra:VGltf:support_animation |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## support_animation #38 +/- ##
====================================================
Coverage ? 58.16%
====================================================
Files ? 23
Lines ? 1121
Branches ? 144
====================================================
Hits ? 652
Misses ? 420
Partials ? 49 ☔ View full report in Codecov by Sentry. |
|
Thank you! |
|
Sorry, I didn't notice that this PR is a draft. If you intended to make more changes, please re-submit PR 🙏 |
|
it has been planned to operation check. if it works well, merging has no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to resolve conflicts of #27 , merge master into support_animation