Fix for broken events when event targets are SVGElementInstances (in Safari)#1970
Open
beckiechoi wants to merge 1 commit intoyui:dev-masterfrom
Open
Fix for broken events when event targets are SVGElementInstances (in Safari)#1970beckiechoi wants to merge 1 commit intoyui:dev-masterfrom
beckiechoi wants to merge 1 commit intoyui:dev-masterfrom
Conversation
… elements in Safari
|
CLA is valid! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W3 states that SVG element be a bit different from the rest of elements. They are a
SVGElementInstance, and don't have attributes likenodeType,nodeName,parentNode, etc. A SVGElementInstance instead has acorrespondingElementor both acorrespondingElementand acorrespondingUseElement(for<use/>). BothcorrespondingElementandcorrespondingUseElementhave all the typical DOM node attributes that you'd expect from other elements.(ref: http://www.w3.org/TR/SVG/struct.html#InterfaceSVGElementInstance)
Funnily enough, Chrome and Firefox do not follow this "standard", but Safari does.
Currently YUI doesn't have a support for it, making event targets to be
nullwhile attempting to wrap a SVGElementInstance into a Y.Node instance; hence this patch.