Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add Google new favicon URL #23020

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samiahmedsiddiqui
Copy link
Contributor

@samiahmedsiddiqui samiahmedsiddiqui commented Jun 26, 2024

Previously, Kapa.ai widget was loading favicon from https://www.google.com/s2/favicons?sz=128&domain=docs.yugabyte.com and we added a rule in CSP to allow loading favicon from this URL.

However, Google recently changed and now it redirects favicon requests. Now, when Kapa.ai widget tries to load the favicon from the https://www.google.com/s2/favicons?sz=128&domain=docs.yugabyte.com, Google redirects to a different URL.

Google has the following subdomains that can serve this request like:

  1. https://t0.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=http://docs.yugabyte.com&size=128
  2. https://t1.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=http://docs.yugabyte.com&size=128
  3. https://t2.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=http://docs.yugabyte.com&size=128
  4. https://t3.gstatic.com/faviconV2?client=SOCIAL&type=FAVICON&fallback_opts=TYPE,SIZE,URL&url=http://docs.yugabyte.com&size=128

This PR is to include all the above URLs in our CSP to resolve favicon loading issues.

Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for infallible-bardeen-164bc9 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 27c71b1
🔍 Latest deploy log https://app.netlify.com/sites/infallible-bardeen-164bc9/deploys/667bbe8a6a1f7f00088f5dd3
😎 Deploy Preview https://deploy-preview-23020--infallible-bardeen-164bc9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant