Skip to content

Commit

Permalink
[#23363] Changing the default gflags of YSQL memory configuration.
Browse files Browse the repository at this point in the history
Summary: Updating the default gflags of yugabyted to use use_memory_defaults_optimized_for_ysql to use memory configuration optimised for YSQL workloads.

Test Plan: Manual Tests

Reviewers: sgarg-yb, djiang

Reviewed By: djiang

Subscribers: djiang, yugabyted-dev

Differential Revision: https://phorge.dev.yugabyte.com/D38085
  • Loading branch information
nchandrappa committed Sep 16, 2024
1 parent 6556498 commit e2b1d28
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions bin/yugabyted
Original file line number Diff line number Diff line change
Expand Up @@ -3213,6 +3213,7 @@ class ControlScript(object):
"--placement_cloud={}".format(self.configs.saved_data.get("cloud_provider")),
"--placement_region={}".format(self.configs.saved_data.get("cloud_region")),
"--placement_zone={}".format(self.configs.saved_data.get("cloud_zone")),
"--use_memory_defaults_optimized_for_ysql=true",
]

if fault_tolerance == "region":
Expand Down Expand Up @@ -3244,8 +3245,9 @@ class ControlScript(object):
os.path.join(self.configs.saved_data.get("data_dir"), "master-info")),
"--master_enable_metrics_snapshotter=true",
"--webserver_port={}".format(self.configs.saved_data.get("master_webserver_port")),
"--default_memory_limit_to_ram_ratio=0.35",
"--instance_uuid_override={}".format(self.configs.saved_data.get("master_uuid")),
"--enforce_tablet_replica_limits=true",
"--split_respects_tablet_replica_limits=true",
]

if self.configs.saved_data.get("secure"):
Expand Down Expand Up @@ -3340,7 +3342,6 @@ class ControlScript(object):
"--tserver_enable_metrics_snapshotter=true",
"--metrics_snapshotter_interval_ms=11000",
"--webserver_port={}".format(self.configs.saved_data.get("tserver_webserver_port")),
"--default_memory_limit_to_ram_ratio=0.6",
"--instance_uuid_override={}".format(self.configs.saved_data.get("tserver_uuid")),
"--start_redis_proxy=false",
"--placement_uuid={}".format(self.configs.saved_data.get("placement_uuid")),
Expand Down

0 comments on commit e2b1d28

Please sign in to comment.