Skip to content

Commit

Permalink
[#23922] docdb: Handle colocated tablets correctly in tablet limit ch…
Browse files Browse the repository at this point in the history
…ecks.

Summary: Currently the tablet limit guardrails treat colocated tables as any other create table request. That is, create table requests to create a colocated table will fail when the universe is close to or at its tablet limit. However, when creating a colocated table besides the first one, the request doesn't actually result in tablets being created and thus the request should succeed. This diff fixes this bug.

Test Plan:
```
./yb_build.sh --with-tests --cxx-test-filter-re tablet_limits_integration_test  --cxx-test tablet_limits_integration_test --gtest_filter 'CreateTableLimitTestRF1.CanAddColocatedTableAtLimit'
./yb_build.sh --with-tests --cxx-test-filter-re tablet_limits_integration_test  --cxx-test tablet_limits_integration_test --gtest_filter 'CreateTableLimitTestRF1.CannotCreateFirstTableInColocatedDatabaseAtLimit'
```

Reviewers: mlillibridge

Reviewed By: mlillibridge

Subscribers: ybase, slingam

Differential Revision: https://phorge.dev.yugabyte.com/D38098
  • Loading branch information
druzac committed Sep 19, 2024
1 parent 7a4b409 commit 4d922ca
Show file tree
Hide file tree
Showing 2 changed files with 232 additions and 152 deletions.
Loading

0 comments on commit 4d922ca

Please sign in to comment.