fix: round props.value to decimal place (#1994) (#1996)

youzan · Dec 27, 2022 · cf67aa4 · cf67aa4
1 parent 02e990f
commit cf67aa4
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/zent/src/number-input/NumberInput.tsx b/packages/zent/src/number-input/NumberInput.tsx
@@ -386,15 +386,19 @@ export class NumberInput extends Component<
         onChange && onChange(this.state.value as number);
       }
     } else {
-      const { onChange, decimal } = this.props;
+      const { onChange, decimal, value: propsValue } = this.props;
       const { value } = this.state as INumberInputDecimalState;
       const roundedStateValue = value.toFixed(decimal);
+      // 外部不规范的使用方式会去修改 onChange 抛出去的值以及它的类型，这里统一转成字符串
+      const roundedPropsValue =
+        typeof propsValue === 'number'
+          ? propsValue.toFixed(decimal)
+          : propsValue;
       if (
         onChange &&
         this.props.value !== '' &&
         this.state.input !== '' &&
-        // 外部传入的 value 有可能类型错误，转成字符串之后再比较
-        String(this.props.value) !== roundedStateValue
+        roundedPropsValue !== roundedStateValue
       ) {
         onChange(roundedStateValue);
       }