Updating MH gateway script to include test_target name in the message to include it in the results link #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating gateway script to include test_target name in the message to include it in the results link
Libzu
changed the title
Datadog ReportBranch report: ✅ 0 Failed, 71865 Passed, 170 Skipped, 12m 35.28s Total Time |
oxve
reviewed
Apr 14, 2025
| for gtest_target in args.targets.split(','): | ||
| _, target_name = gtest_target.split(':') | ||
| print(f' Processing gtest_target: {gtest_target}') | ||
| # print(f' Processing gtest_target: {gtest_target}') |
Collaborator
There was a problem hiding this comment.
Remove (and the other commented out statement below)? I don't think we need this arg as the gtest filter will be displayed in the target log.
| # print(f' gtest_filter = {gtest_filter}') | ||
| if gtest_filter == '-*': | ||
| print(f'Skipping {target_name} due to test filter.') | ||
| # print(f'Skipping {target_name} due to test filter.') |
Collaborator
There was a problem hiding this comment.
Keep this one though so it's clear that the target was skipped.
copybara-service
bot
force-pushed
the
main
branch
from
6259a06 to
d7a2be9
Compare
SortaCookie
force-pushed
the
main
branch
7 times, most recently
from
e6b6385 to
b41ef6d
Compare
copybara-service
bot
force-pushed
the
main
branch
from
b41ef6d to
b2f8e30
Compare
SortaCookie
force-pushed
the
main
branch
7 times, most recently
from
c735912 to
caa08fe
Compare
SortaCookie
force-pushed
the
main
branch
3 times, most recently
from
097e9c9 to
c41cdd0
Compare
copybara-service
bot
force-pushed
the
main
branch
from
c41cdd0 to
7dc7279
Compare
SortaCookie
force-pushed
the
main
branch
25 times, most recently
from
bd772ba to
784320a
Compare
copybara-service
bot
force-pushed
the
main
branch
from
784320a to
6038abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update on_device_tests_gateway_client.py
Updating gateway script to include test_target name in the message to include it in the results link