Test with new label to run tests only on experimental workers.

.github/CODEOWNERS

@@ -8,5 +8,6 @@
 /components/viz/service/display/starboard/  # no owners
 /ui/ozone/platform/starboard/  # no owners
 /cobalt/build/gn.py @youtube/cobalt-build
+/third_party/blink/ @youtube/cobalt-web-api
 
 *.nplb_filter.json @youtube/nplb-filters

.github/actions/build/action.yaml

@@ -2,7 +2,7 @@ name: Build Cobalt
 description: Builds Cobalt targets
 inputs:
   targets:
-    description: "List of ninja targets for Cobalt build."
+    description: "JSON list of ninja targets for Cobalt build."
     required: true
   test_root_target:
     description: "The root target from which to deduce what tests to run."
@@ -16,6 +16,9 @@ inputs:
   upload_on_device_test_artifacts:
     description: "Indicates if on-device test artifacts should be uploaded."
     required: true
+  upload_web_test_artifacts:
+    description: "Indicates if web test artifacts should be uploaded."
+    required: true
   test_artifacts_key:
     description: "Artifact key used to store on-host test artifacts."
     required: true
@@ -43,16 +46,25 @@ runs:
           git diff --name-only -r ${{ github.event.pull_request.base.sha }} ${{ github.event.pull_request.head.sha }} > ${CHANGED_FILES_LIST}
         shell: bash
       - name: Calculate test targets
-        if: matrix.config == 'devel' && inputs.test_root_target != 'null'
+        if: matrix.config == 'devel' && (inputs.test_root_target != 'null' || inputs.upload_web_test_artifacts == 'true')
         id: calculate-test-targets
         env:
           CHANGED_FILES_LIST: changed_files.txt
           ROOT_TARGET: ${{ inputs.test_root_target }}
+          IS_WEB_TESTS: ${{ inputs.upload_web_test_artifacts }}
           STATIC_TEST_TARGETS_JSON_FILE: cobalt/build/testing/targets/${{ matrix.platform }}/test_targets.json
           # TODO(b/382508397): Replace hardcoded list with dynamically generated one.
           DYN_TEST_TARGETS_JSON_FILE: out/${{ matrix.platform }}_${{ matrix.config }}/dyn_targets.json
         run: |
           set -x
+
+          if [[ ${IS_WEB_TESTS} == "true" ]]; then
+            test_targets_json='[":blink_web_tests"]'
+            echo "test_targets_json=${test_targets_json}" >> $GITHUB_OUTPUT
+            echo "test_targets_count=1" >> $GITHUB_OUTPUT
+            exit 0
+          fi
+
           cd src
           gn desc out/${{ matrix.platform }}_${{ matrix.config }}/ "*" --format=json > gn_desc.json
           # Trim any warning gn printed before the json (all lines above the first curly brace).
@@ -99,12 +111,22 @@ runs:
         shell: bash
       - name: Ninja build
         env:
-          TARGETS: ${{ inputs.targets }}
+          TARGETS_JSON: ${{ inputs.targets }}
         run: |
           set -ex
           cd src
+          TARGETS=$(echo "${TARGETS_JSON}" | jq -cr '. | join(" ")')
           time autoninja -C out/${{ matrix.platform }}_${{ matrix.config }} ${TARGETS}
         shell: bash
+      - name: Generate License File
+        if: startsWith(matrix.platform, 'android') && !contains(matrix.platform, 'chromium')
+        run: |
+          set -ex
+          cd src
+          out_dir=out/${{ matrix.platform }}_${{ matrix.config }}
+          tools/licenses/licenses.py credits --gn-target cobalt:gn_all --gn-out-dir ${out_dir} \
+            > ${out_dir}/licenses_cobalt.txt
+        shell: bash
       - name: Archive Android APKs
         if: startsWith(matrix.platform, 'android') && matrix.config == 'qa'
         uses: actions/upload-artifact@v4
@@ -119,6 +141,6 @@ runs:
         uses: ./src/.github/actions/upload_test_artifacts
         with:
           test_artifacts_key: ${{ inputs.test_artifacts_key }}
-          upload_on_host_test_artifacts: ${{ inputs.upload_on_host_test_artifacts }}
+          upload_on_host_test_artifacts: ${{ inputs.upload_on_host_test_artifacts == 'true' || inputs.upload_web_test_artifacts == 'true' }}
           upload_on_device_test_artifacts: ${{ inputs.upload_on_device_test_artifacts }}
-          test_targets_json_file: ${{ inputs.test_targets_json_file }}
+          test_targets_json: ${{ steps.calculate-test-targets.outputs.test_targets_json }}

.github/actions/depot_tools/action.yaml

@@ -1,5 +1,9 @@
 name: Set Up Depot Tools
 description: Sets up Depot Tools and initializes gclient.
+inputs:
+  run_sync:
+    description: "Whether or not to run gclient sync."
+    default: "true"
 runs:
   using: "composite"
   steps:
@@ -13,8 +17,27 @@ runs:
       - name: Add depot tools to PATH
         run: echo "$GITHUB_WORKSPACE/depot_tools" >> $GITHUB_PATH
         shell: bash
+      - name: Set GIT_CACHE_PATH
+        run: export GIT_CACHE_PATH=/gclient-sync-cache
+        shell: bash
+      # - name: Write test if doesn't exist
+      #   run: touch /gclient-sync-cache/helloworld.txt
+      #   shell: bash
+      - name: Write test if doesn't exist
+        run: |
+          ls -la /
+          ls -la /gclient-sync-cache
+          echo "0" >> /gclient-sync-cache/helloworld.txt
+          ls -la /gclient-sync-cache
+        shell: bash
+      - name: See whats there
+        run: ls /gclient-sync-cache
+        shell: bash
+      - name: Testing writing
+        run: sed -i 's/\([0-9]\+\)/$((\1+1))/g' /gclient-sync-cache/helloworld.txt && sleep 1000000
+        shell: bash
       - name: Generate gclient file
-        run: gclient config --name=src --custom-var=download_remoteexec_cfg=True --custom-var='rbe_instance="projects/cobalt-actions-prod/instances/default_instance"' https://github.com/${{ github.repository }}
+        run: gclient config --cache-dir=/gclient-sync-cache --name=src --custom-var=download_remoteexec_cfg=True --custom-var='rbe_instance="projects/cobalt-actions-prod/instances/default_instance"' https://github.com/${{ github.repository }}
         shell: bash
       - name: Set target OS for Android
         if: ${{ contains(matrix.platform, 'android') }}
@@ -23,6 +46,7 @@ runs:
           gclient validate
         shell: bash
       - name: gclient sync
+        if: inputs.run_sync == 'true'
         run: gclient sync -v --shallow --no-history -r ${{ github.sha }} --cache-dir=/gclient-sync-cache
         shell: bash
       - name: Disable Chromium client side build telemetry

.github/actions/docker/action.yaml

@@ -80,4 +80,4 @@ runs:
       run: |
         docker push ${DOCKER_TAG}
         docker push ${DOCKER_FLOATING_TAG}
-      shell: bash
+      shell: bash

.github/actions/on_device_tests/action.yaml

@@ -98,7 +98,7 @@ runs:
         # Test results (xml and logs) must be in a subfolder in results_dir
         # to be picked up by the test result processor.
         mkdir -p "${test_output}/${{ matrix.platform }}"
-        gsutil cp -r "${{ inputs.gcs_results_path }}/" "${test_output}/${{ matrix.platform }}"
+        gsutil -q cp -r "${{ inputs.gcs_results_path }}/" "${test_output}/${{ matrix.platform }}"
       shell: bash
     - name: Archive Test Results
       uses: actions/upload-artifact@v4

.github/actions/print_logs/action.yaml

@@ -33,15 +33,14 @@ runs:
           "${GITHUB_WORKSPACE}/src/out/${{ matrix.platform }}_${{ matrix.config }}/lib.unstripped/
       shell: bash
     - run: |
-        set -x
         # Enable globstar shell option for globstar paths e.g. /**/*.xml and
         # nullopt to returns empty string if the glob matches no files.
         shopt -s globstar nullglob
 
         log_files=(${{ inputs.logfile_glob }})
 
         if [ ${#log_files[@]} -eq 0 ]; then
-          echo "::error::No log files were collected."
+          echo "::error::No log files were collected. The tests probably failed to run."
           exit 1
         else
           for log_file in ${log_files[@]}; do
@@ -50,6 +49,7 @@ runs:
               # TODO: stack.py fails import packages. Perhaps needs depot tools setup?
               cat ../${log_file} | python3 third_party/android_platform/development/scripts/stack.py --pass-through --output-directory out/${{ matrix.platform }}_${{ matrix.config }}/
             else
+              echo "=== ${log_file} ==="
               cat ${log_file}
             fi
           done

.github/actions/process_test_results/action.yaml

@@ -6,7 +6,7 @@ inputs:
     required: true
   datadog_api_key:
     description: "Path to directory where test results are saved."
-    required: true
+    default: ''
   results_path:
     description: "Path (or glob) to test result xml files."
     required: true

.github/actions/upload_test_artifacts/action.yaml

@@ -10,13 +10,15 @@ inputs:
   test_artifacts_key:
     description: "Artifact key used to store on-host test artifacts."
     required: true
-  test_targets_json_file:
-    description: "File containing the test target json."
+  test_targets_json:
+    description: "The test targets as a json list."
     required: true
 runs:
   using: "composite"
   steps:
     - name: Archive Test Artifacts
+      env:
+        TEST_TARGETS_JSON: ${{ inputs.test_targets_json }}
       run: |
         set -x
         mkdir ${GITHUB_WORKSPACE}/artifacts
@@ -27,7 +29,7 @@ runs:
           --out-dir out/${{ matrix.platform }}_${{ matrix.config }}/ \
           --destination-dir ${GITHUB_WORKSPACE}/artifacts \
           --platform ${{ matrix.platform }} \
-          --targets $(cat "${{ inputs.test_targets_json_file }}" | jq -cr '.test_targets | join(",")')
+          --targets $(echo "${TEST_TARGETS_JSON}" | jq -cr 'join(",")')
       shell: bash
     - name: Upload On-Host Test Artifacts Archive
       if: inputs.upload_on_host_test_artifacts == 'true'

.github/actions/web_tests/action.yaml

@@ -0,0 +1,56 @@
+name: Web Tests
+description: Runs Blink Web Tests.
+inputs:
+  test_artifacts_key:
+    description: "Artifact key used to store test artifacts."
+    required: true
+  test_results_key:
+    description: "Artifact key used to store test results."
+    required: true
+runs:
+  using: "composite"
+  steps:
+    - name: Download Artifacts
+      uses: actions/download-artifact@v4
+      with:
+        name: ${{ inputs.test_artifacts_key }}
+    - name: Extract Artifacts
+      shell: bash
+      run: |
+        set -x
+        # The web tests fail when not run from the source folder. Use the existing checkout.
+        cd src/
+        tar xf ../test_artifacts.tar.gz
+    - name: Run Web Tests
+      id: run-tests
+      shell: bash
+      env:
+        # TODO: Once fixed this should be expanded to include more tests.
+        TEST_PATH: wpt_internal/cobalt/crash-log
+      run: |
+        set -x
+        env
+        cd src/
+
+        # Web-tests expect dump_syms and minidump_stackwalk to be present at the root of the out folder.
+        out_dir="out/${{ matrix.platform}}_${{ matrix.config }}"
+        cp ${out_dir}/clang_x64/{dump_syms,minidump_stackwalk} ${out_dir}/
+
+        RESULTS_DIR="out/${{ matrix.platform}}_${{ matrix.config }}/layout-test-results"
+        echo "RESULTS_DIR=${RESULTS_DIR}" >> $GITHUB_ENV
+
+        third_party/blink/tools/run_web_tests.py \
+          --driver-logging \
+          --additional-driver-flag="--no-sandbox" \
+          --debug \
+          --no-show-results \
+          --target ${{ matrix.platform}}_${{ matrix.config }} \
+          ${TEST_PATH}
+
+        echo "Finished running tests..."
+    - name: Archive Test Results
+      if: always() && contains(fromJson('["success", "failed"]'), steps.run-tests.outcome)
+      uses: actions/upload-artifact@v4
+      with:
+        name: ${{ inputs.test_results_key }}
+        path: src/${{ env.RESULTS_DIR }}/*

.github/workflows/label-cherry-pick.yaml

@@ -112,24 +112,18 @@ jobs:
             ${{ github.event.pull_request.body }}
 
       - name: Comment on failure
+        if: steps.create-pr.outputs.pull-request-number == ''
         uses: actions/github-script@v6
         with:
           github-token: ${{ secrets.CHERRY_PICK_TOKEN }}
           script: |
-            if ('${{ steps.create-pr.outputs.pull-request-number }}' == '') {
-              // Comment on the originating PR if creating a cherry pick PR failed.
-              github.rest.issues.createComment({
-                issue_number: context.payload.number,
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                body: '> [!IMPORTANT]\n> Creating the cherry pick PR failed! Check the log at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} for details.'
-              });
-            } else if ('${{ steps.cherry-pick.outcome }}' == 'failure') {
-              // Comment on the new PR if the cherry pick failed.
-              github.rest.issues.createComment({
-                issue_number: '${{ steps.create-pr.outputs.pull-request-number }}',
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                body: '> [!IMPORTANT]\n> There were merge conflicts while cherry picking! Check out [${{ env.CHERRY_PICK_BRANCH }}](${{ github.repository }}/tree/${{ env.CHERRY_PICK_BRANCH }}) and fix the conflicts before proceeding. Check the log at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} for details.'
-              });
-            }
+            // Comment on the originating PR if creating a cherry pick PR failed.
+            github.rest.issues.createComment({
+              issue_number: context.payload.number,
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              body: '> [!IMPORTANT]\n> Creating the cherry pick PR failed! Check the log at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} for details.'
+            });
+      - name: Post review
+        if: steps.cherry-pick.outcome == 'failure' && steps.create-pr.outputs.pull-request-number != ''
+        run: gh pr review 123 -r -b "> [!IMPORTANT]\n> There were merge conflicts while cherry picking! Check out [${{ env.CHERRY_PICK_BRANCH }}](${{ github.repository }}/tree/${{ env.CHERRY_PICK_BRANCH }}) and fix the conflicts before proceeding. Check the log at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} for details."

.github/workflows/lint.yaml

@@ -21,7 +21,7 @@ jobs:
   lint:
     name: Pre-Commit
     runs-on: ubuntu-latest
-    timeout-minutes: 10
+    timeout-minutes: 20
     steps:
       - name: Install pre-commit
         run: |