Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seccomp: Add a case for checking arguments #2775

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Apr 29, 2024

As the title says.

Part of #2724

Next, I'd like to make it abstract(e.g., SeccompRule) based on this PR.

@utam0k utam0k added the kind/experimental `/experimental` label Apr 29, 2024
@utam0k utam0k requested a review from a team April 29, 2024 12:41
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM
I don't understand all of the changes here, but in general looks good, and experimental changes, so approving.

Also, I hope the async is only for the demo/example, I'd prefer the actual library code to not have any async in it if possible.

@YJDoc2 YJDoc2 merged commit ba1b28e into youki-dev:main May 6, 2024
30 checks passed
@github-actions github-actions bot mentioned this pull request May 3, 2024
@utam0k
Copy link
Member Author

utam0k commented May 6, 2024

Also, I hope the async is only for the demo/example, I'd prefer the actual library code to not have any async in it if possible.

Of course, I intend to use async/await in main.rs for seccomp notify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/experimental `/experimental`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants