Add execCPUAffinity to the runtime process spec
#174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keisku
force-pushed
the
issue168
branch
2 times, most recently
from
a5b7a17 to
9412a02
Compare
keisku
commented
Jun 28, 2024
Comment on lines
+567
to
+588
| /// ExecCPUAffinity specifies CPU affinity used to execute the process. | ||
| /// This setting is not applicable to the container's init process. | ||
| pub struct ExecCPUAffinity { | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| /// cpu_affinity_initial is a list of CPUs a runtime parent process to be run on | ||
| /// initially, before the transition to container's cgroup. | ||
| /// This is a a comma-separated list, with dashes to represent ranges. | ||
| /// For example, `0-3,7` represents CPUs 0,1,2,3, and 7. | ||
| cpu_affinity_initial: Option<String>, | ||
|
|
||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| /// cpu_affinity_final is a list of CPUs the process will be run on after the transition | ||
| /// to container's cgroup. The format is the same as for `initial`. If omitted or empty, | ||
| /// the container's default CPU affinity, as defined by cpu.cpus property, is used. | ||
| cpu_affinity_final: Option<String>, |
There was a problem hiding this comment.
Originally fields in execCPUAffinity are initial and final.
Since final is a reserved keyword in Rust, I added cpu_affinity_ as prefix.
|
PTAL @utam0k |
|
@keisku do you mind a rebase? |
Signed-off-by: keisku <[email protected]>
keisku
force-pushed
the
issue168
branch
2 times, most recently
from
58232ff to
6e72c7d
Compare
|
After rebasing it, I think we should add validation to |
|
@utam0k PTAL |
utam0k
approved these changes
Jul 2, 2024
|
Sorry for the late |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #168
Used #136 as a reference to add new field to the spec.