-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rlimit: Make rlimits POSIX-specific #172
Conversation
As described in the issue youki-dev#171, oci-spec-rs need support POSI-specific Rlimit(PosixRlimit) but not LinuxRlimit. Fixes youki-dev#171 Signed-off-by: Alex Lyn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM.
We may want to add a bunch of cross compilation target to the CI. 🤔
Hi @utam0k I need your help to review this PR. PTAL! Thx very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think this should be considered a breaking change in the |
@Mossaka Thanks for letting us know about this problem. |
I'll tackle the problem the next weekend. |
Is there a plan to release |
As described in the issue #171, oci-spec-rs need support POSI-specific Rlimit(PosixRlimit) but not LinuxRlimit.
Fixes #171