Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rlimit: Make rlimits POSIX-specific #172

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

Apokleos
Copy link
Contributor

@Apokleos Apokleos commented Jun 7, 2024

As described in the issue #171, oci-spec-rs need support POSI-specific Rlimit(PosixRlimit) but not LinuxRlimit.

Fixes #171

As described in the issue youki-dev#171, oci-spec-rs need support
POSI-specific Rlimit(PosixRlimit) but not LinuxRlimit.

Fixes youki-dev#171

Signed-off-by: Alex Lyn <[email protected]>
Copy link
Contributor

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

We may want to add a bunch of cross compilation target to the CI. 🤔

@Apokleos
Copy link
Contributor Author

Hi @utam0k I need your help to review this PR. PTAL! Thx very much.

Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@utam0k utam0k merged commit da761c5 into youki-dev:main Jun 13, 2024
6 checks passed
@Mossaka
Copy link

Mossaka commented Jul 9, 2024

I think this should be considered a breaking change in the v0.6.7 since it modifies public API.

@utam0k
Copy link
Member

utam0k commented Jul 10, 2024

I think this should be considered a breaking change in the v0.6.7 since it modifies public API.

@Mossaka Thanks for letting us know about this problem.
We know this PR led to the breaking change, but it's a problem that there is a no way to notice breaking changes for oci-spec-rs's users.

@utam0k
Copy link
Member

utam0k commented Jul 10, 2024

I'll tackle the problem the next weekend.

@Mossaka
Copy link

Mossaka commented Jul 10, 2024

Is there a plan to release v1.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make rlimits POSIX-specific
4 participants