State: align ocispec-rs with spec-go and introduce State #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes youki-dev#169 Signed-off-by: Alex Lyn <[email protected]>
|
Hi @utam0k @saschagrunert PTAL! Thx very much. |
Comment on lines
+23
to
+24
| /// Paused indicates that the container exists, but all processes are paused. | ||
| Paused, |
There was a problem hiding this comment.
Is this something official? I can't see it in https://github.com/opencontainers/runtime-spec/blob/main/specs-go/state.go
There was a problem hiding this comment.
I'm so sorry @saschagrunert
I think I misunderstood the State of things and mixed them up. I need to rethink it. Thank you for your reminder.
Comment on lines
+30
to
+32
| /// Unknown | ||
| #[default] | ||
| Unknown, |
There was a problem hiding this comment.
Same for this, do we need that?
| pid: i32, | ||
|
|
||
| /// opaque metadata. | ||
| #[serde(default)] |
There was a problem hiding this comment.
Suggested change
| #[serde(default)] | |
| #[serde(default, skip_serializing_if = "Option::is_none")] |
|
Sorry @saschagrunert @utam0k for that my misunderstanding of this state, I think I should close it. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169